Would conditional citizenship be beneficial?

In the Robert Heinlein book Starship Troopers (much better, and almost completely different than the movie), he talks about a society where full citizenship isn’t granted until one has served in the military in some capacity. If someone chooses not to serve, they still have all the rights granted to a citizen, except that they can’t vote or hold politicial office. The idea is that the ability to make changes in government is restricted to those who have shown a willingness to put the country’s needs before thier own—to sacrifice. Of course, there would be opportunities for everyone to serve in some capacity or another, regardless of physical limitations.

Would this result in a better or worse society?